Re: Tiling Shader Buildings

1. Ok, it's work.
However, if I delete a selected building while I have the buildings manager open this crashes and shows this message:

MissingReferenceException: The object of type 'RealWorldTerrainOSMMeta' has been destroyed but you are still trying to access it.
Your script should either check if it is null or you should not destroy the object.
UnityEngine.Object.get_name () (at C:/buildslave/unity/build/Runtime/Export/UnityEngineObject.bindings.cs:198)
InfinityCode.RealWorldTerrain.Tools.RealWorldTerrainBuildingManager.OnGUI () (at Assets/Infinity Code/Real World Terrain/Scripts/Editor/Tools/RealWorldTerrainBuildingManager.cs:64)
System.Reflection.MonoMethod.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at <e1319b7195c343e79b385cd3aa43f5dc>:0)
Rethrow as TargetInvocationException: Exception has been thrown by the target of an invocation.
System.Reflection.MonoMethod.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at <e1319b7195c343e79b385cd3aa43f5dc>:0)
System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) (at <e1319b7195c343e79b385cd3aa43f5dc>:0)
UnityEditor.HostView.Invoke (System.String methodName, System.Object obj) (at C:/buildslave/unity/build/Editor/Mono/HostView.cs:342)
UnityEditor.HostView.Invoke (System.String methodName) (at C:/buildslave/unity/build/Editor/Mono/HostView.cs:336)
UnityEditor.HostView.OldOnGUI () (at C:/buildslave/unity/build/Editor/Mono/HostView.cs:129)
UnityEngine.Experimental.UIElements.IMGUIContainer.DoOnGUI (UnityEngine.Event evt, UnityEngine.Matrix4x4 worldTransform, UnityEngine.Rect clippingRect, System.Boolean isComputingLayout) (at C:/buildslave/unity/build/Modules/UIElements/IMGUIContainer.cs:244)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr) (at C:/buildslave/unity/build/Modules/IMGUI/GUIUtility.cs:179)

Re: Tiling Shader Buildings

9.6. Incredible work Alex, congratulations! I am a technical artist so I certainly cannot fully understand the difficulty of what you are doing but I believe you are a phenomenon!

The union of the buildings is excellent, even the management of the multi-sub-object by the materials is something that I didn't think could be so quick.

I only noticed one bug:
the combined buildings are always called the same and as soon as I generate a second group of buildings, the first one is destroyed.

Re: Tiling Shader Buildings

Yes, the groups are named the same.
I just didn't make it have different names because I don't know what it might be useful for.

When generating the second group, the first is not destroyed.
I just checked it out.
Also, if the first group were destroyed, how would you know that the groups have the same name?!

Re: Tiling Shader Buildings

I know because the game object remains empty.

I try to make a video later so I'll show you how I make it disappear

Re: Tiling Shader Buildings

9. Try this Dropbox link, i hope this works better:

https://www.dropbox.com/s/mfhp9ezsmba9a … 9.mp4?dl=0

Re: Tiling Shader Buildings

9. It's work well!
Thanks Alex!

Re: Tiling Shader Buildings

Hi Alex all right?
Sorry if I still bother you. Of the amazing changes you made from step 1 to step 8 it all works.

9.
For point 9, the union of the buildings, there is a problem with the subdivision of the roofs.
In the attached image you can see that the roofs are deleted in each group that is created later and remain only in the last one.
I think it's the same problem we encountered in joining the buildings.

Can you fix it please?
Thanks

Post's attachments

Attachment icon 09.jpg 643.35 kb, 3 downloads since 2020-12-03 

Re: Tiling Shader Buildings

I just tested combining of building and it works correctly on my side.
Please make a short video so I can repeat your steps and reproduce the problem.

Re: Tiling Shader Buildings

Okay, I double checked.  made a mistake.

Since I tested the asset on another project I forgot to replace the script "RealWorldTerrainContainerEditor" you passed me apart.
Now everything works fine!

Can you release an updated package so that all changes are bundled?
Thanks a lot!

Re: Tiling Shader Buildings

First there will be an update release for Online Maps.
Then I need to finish a few more features for RWT.
The release of the new version of RWT is scheduled for late next week.

Re: Tiling Shader Buildings

Perfect! Thanks

Re: Tiling Shader Buildings

Hi Alex, sorry if i still bother you.

I downloaded the latest version of the asset 4.5.7.2.
It seemed to me that I didn't encounter this problem when we did the tests, but maybe it just didn't happen:

When I go to join the buildings together the roofs are joined on another game object for which I have no correspondence between wall and roof: /
I am sending you a screenshot to make you understand what I mean.

I would like if I selected an area of buildings and, using the Combine Selected Buildings command, selected walls and roofs were joined together.
Do you think it is possible?
Thanks


Another thing, I don't know what it depends on, when I imported the new version of the asset it started giving me this error:

NullReferenceException: Object reference not set to an instance of an object
InfinityCode.RealWorldTerrain.Editors.RealWorldTerrainContainerEditor.DrawBaseDist () (at Assets/Infinity Code/Real World Terrain/Scripts/Editor/Editors/RealWorldTerrainContainerEditor.cs:253)
InfinityCode.RealWorldTerrain.Editors.RealWorldTerrainContainerEditor.OnInspectorGUI () (at Assets/Infinity Code/Real World Terrain/Scripts/Editor/Editors/RealWorldTerrainContainerEditor.cs:620)
UnityEditor.InspectorWindow.DoOnInspectorGUI (System.Boolean rebuildOptimizedGUIBlock, UnityEditor.Editor editor, System.Boolean wasVisible, UnityEngine.Rect& contentRect) (at C:/buildslave/unity/build/Editor/Mono/Inspector/InspectorWindow.cs:1625)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr)

Post's attachments

Attachment icon Screen01.jpg 1.87 mb, 1 downloads since 2021-01-11 

Re: Tiling Shader Buildings

Hello.

About the issue with RWT Container Editor:
The problem has been fixed.
Thank you for reporting this.
I sent you the modified script by email.
This fix will be released in the next version of the asset.

About combining buildings:
We've already discussed this here:
https://forum.infinity-code.com/viewtop … 6894#p6894

Re: Tiling Shader Buildings

Thanks Alex,
ok for the roofs and walls issue.