Infinity Code Forum — Buildings plugin

Re: Buildings plugin

null@example.com (Alex Vertax) — Tue, 23 Jan 2018 18:25:10 +0000

Yes, you can determine when the buildings are done.

Re: Buildings plugin

null@example.com (Quidam) — Tue, 23 Jan 2018 01:54:24 +0000

Okay, thanks.

I was saying I've got OnBuildingCreated firing after OnAllBuildingsCreated fires, which confuses me. Once all buildings have been created, I wouldn't expect to be notified that a building was created.

In the next version, if I check both OnAllBuildingsCreated & OnRequestFailed, I'll be able to determine when the buildings are done?

Re: Buildings plugin

null@example.com (Alex Vertax) — Tue, 23 Jan 2018 01:06:05 +0000

No, OnAllBuildingsCreated will only triggered if at least one building has been generated.

Right now you need to use OnRequestSent trick.
But thanks that you show me this problem.
We added OnRequestFailed so that no one in the future needed to do this.
The next version will contain this.

Yes, now buildings are generated using inner ways too.

Unfortunately, I did not understand what you mean in the last post.
Please rephrase it.

Re: Buildings plugin

null@example.com (Quidam) — Mon, 22 Jan 2018 20:27:48 +0000

OnAllBuildingsCreated doesn't seem to be working for me. I drop a debug in there and in OnBuildingCreated and I'm getting notifications of buildings being created after being notified that they all already have been.

Am I missing something?

Re: Buildings plugin

null@example.com (Quidam) — Mon, 22 Jan 2018 19:27:58 +0000

Awesome, that makes sense. I appreciate the explanation.

I'll also be sure to go ahead and implement OnlineMapsBuildings.OnAllBuildingsCreated. Does this trigger if there are no buildings to create, or must the code in OnRequestSent still be run?

Also, on another note earlier in this thread, and since I missed some of the updates more recently, has there been any change in the way donut-shaped buildings are handled? Last I heard I think it was just the outer way defining the building, so at least they were showing up somewhat properly.

Re: Buildings plugin

null@example.com (Alex Vertax) — Mon, 22 Jan 2018 18:27:47 +0000

First of all, starting from Online Maps v2.5.12 you can use OnlineMapsBuildings.OnAllBuildingsCreated.

How it works in the current script:
OnRequestSent is needed to get an instance of the request, and handle the situation when the map has no buildings. For example, there are no buildings in the sea, or it could just be a server error. In any case, this behavior must be handled.
The request is a private field, so you can get an instance of request only using reflection.

Online Maps take time to generate buildings.
An average of 1 millisecond per building.
But the map can contain hundreds and thousands of buildings at the same time (for example, New York or Moscow).
If you generate this number of buildings at the same time, it will just freeze your application for a few seconds.
Therefore, the map splits the generation of buildings into several frames (50 milliseconds per frame).

OnBuildingCreated will be invoked in each frame at least once.
In the frame when this action is not invoked, the generation of buildings was completed.

Re: Buildings plugin

null@example.com (Quidam) — Mon, 22 Jan 2018 17:23:33 +0000

I have the code you provided for detecting when all the building have been rendered working, but don't get exactly how you're using it. As I'm working more in the initialization routines of my scene, I find myself wanting to be sure I understand it. Could I ask you to explain it a bit? I'm adding in some comments to explain my confusion and what I think's going on. Thanks!

Alex Vertax wrote:

Example:

using System;
using System.Reflection;
using UnityEngine;

public class WaitingBuildingsCreation:MonoBehaviour
{
    private bool hasBuildingCreated = false;
    private bool firstBuildingCreated = false;
    private OnlineMapsBuildings buildings;

    private void Start()
    {
        buildings = OnlineMapsBuildings.instance;

        if (buildings.zoomRange.InRange(OnlineMaps.instance.zoom))
        {
            buildings.OnBuildingCreated += OnBuildingCreated;
            buildings.OnRequestSent += OnRequestSent;
        }
        else OnFinish();
    }

    private void OnRequestSent()
    {
        // Dirty hack to find out that the map does not have buildings.
        Type btype = typeof(OnlineMapsBuildings);
        FieldInfo field = btype.GetField("osmRequest", BindingFlags.Instance | BindingFlags.NonPublic);
        OnlineMapsOSMAPIQuery request = field.GetValue(buildings) as OnlineMapsOSMAPIQuery;
        request.OnComplete += OnRequestComplete;

        buildings.OnRequestSent -= OnRequestSent;

// my understanding here is that because a lack of building on the map means we won't get an event saying when one's created, so we can't know when they're done being created. We tie into the request so if it comes back and is too small, we know there aren't any buildings.

    }

    private void OnRequestComplete(string s)
    {
        if (s.Length < 300) OnFinish();
    }

    private void OnBuildingCreated(OnlineMapsBuildingBase building)
    {
        firstBuildingCreated = true;
        hasBuildingCreated = true;
    }

    private void OnFinish()
    {
        buildings.OnBuildingCreated -= OnBuildingCreated;

        Debug.Log("All buildings are created.");
        Destroy(this);
    }

    private void Update()
    {

// while this line makes sense to me
        if (!firstBuildingCreated) return;

// it's here where I get confused. it seems to me that this is relying on a building being created every frame, otherwise this update loop my execute on the next frame without the building creation triggering hasBuildingCreated. Is this so? Can this be relied upon? Is there any other way to determine the number of building to be displayed on the map so we know when we've shown them all?

        if (hasBuildingCreated)
        {
            hasBuildingCreated = false;
            return;
        }

        OnFinish();
    }
}

Re: Buildings plugin

null@example.com (Alex Vertax) — Wed, 12 Apr 2017 22:32:42 +0000

Unfortunately, we does not have examples for generating objects based on OSM data.

Re: Buildings plugin

null@example.com (Quidam) — Wed, 12 Apr 2017 17:37:59 +0000

That's great, thanks. I'll hold off then on implementing the code you provided above, since a better version is due later this week. I appreciate the example, though, as it shows me how to modify such calls should I need to.

I'm actually considering adapting the building code to allow me to draw lines on the map to represent ways and relations found in OSM- the border of a playground, for example, or a golf course, or some other feature that isn't a building. If you have any examples or suggestions on how to do it more easily, I'd love to see them. If not, I'll work on it myself and if I get to the point where I've got something I think the community would find useful, I'll be sure to share it here.

Re: Buildings plugin

null@example.com (Alex Vertax) — Tue, 11 Apr 2017 12:44:01 +0000

First of all, you do not need to modify the code to change the request.
Use OnlineMapsBuildings.OnPrepareRequest.
Example:

using System;
using UnityEngine;

public class OnPrepareBuildingRequestExample
{
    private void Start()
    {
        OnlineMapsBuildings.instance.OnPrepareRequest += OnPrepareRequest;
    }

    private string OnPrepareRequest(string originalRequest, Vector2 topLeftCoords, Vector2 bottomRightCoords)
    {
        return String.Format("(way[{4}]({0},{1},{2},{3});relation[{4}]({0},{1},{2},{3}););out;>;out skel qt;", bottomRightCoords.y, topLeftCoords.x, topLeftCoords.y, bottomRightCoords.x, "'building'");
    }
}

If you use this request directly, you will have a rather strange result.
I tested the map in Rome (near to coliseum), and it looks a pretty bad.

We have made changes to the code, and now it works correctly with relations, but uses only the outer ways.
The new version will be available later this week.

Re: Buildings plugin

null@example.com (Quidam) — Mon, 10 Apr 2017 17:20:20 +0000

Wondering if you've had a chance to think on this more. As it stands, any time you update I need to keep replacing your code with the line I mentioned in post 16 so that there aren't buildings that don't show up at all.

You said, "If only generate outer way, the building will not look as marked on OSM." To me, at least, that would be preferable to the building now showing up at all. I haven't had a chance to mess with the CSG asset I mentioned yet, and hopefully I won't have to if your team can come up with a workable solution. Please let me know your thoughts on the matter.

Thanks!

Re: Buildings plugin

null@example.com (Quidam) — Wed, 22 Mar 2017 19:35:49 +0000

Using that line of code in post 16, I get meshes for the building, but also ones for the negative space inside them. I'm wondering if the best way to achieve the goal might be through an implementation of Constructive Solid Geometry, taking the negative space meshes and subtracting them from the main building mesh. I found a free asset that looks like it might do the trick, but I thought I'd pass the idea along to you before I got too far into it.

https://www.assetstore.unity3d.com/en/#!/content/47418

Re: Buildings plugin

null@example.com (Quidam) — Wed, 22 Mar 2017 17:06:22 +0000

After poking at it a bit more, I've decided to use the following code for the time being.

requestData = String.Format("(way[{4}]({0},{1},{2},{3});relation[{4}]({0},{1},{2},{3}););out;>;out skel qt;", bry, tlx, tly, brx, "'building'");

It doesn't cut out the holes by implementing the inner ways, but for my purposes at the moment that's acceptable. At some point later I'll want to revisit the issue if you haven't fixed it by then, but just having the exterior borders of every building defined is worth the loss of the interior spaces.

I'd rather have all the buildings be there with some of them being imperfect than the ones that would be imperfect not there at all.

Thanks again!

Re: Buildings plugin

null@example.com (Quidam) — Mon, 20 Mar 2017 23:53:39 +0000

Thanks for the suggestions, I'll start looking into them.

I see what you mean, but I hope it doesn't end up being more trouble than it's worth, as it'd be nice to have a fully functional buildings component before the next major revision. If you don't end up implementing it and I find a way, I'll be sure to share it with the community.

Re: Buildings plugin

null@example.com (Alex Vertax) — Mon, 20 Mar 2017 22:40:29 +0000

You have several ways:
1. The easiest way is increase "Min Building Height".
2. When updating elevation data, you check the elevation for key points (for example, center + middle of bounding box edges), and update the roof points. It will be very similar to the example above (post 11), and I think you will do it without problems.
3. When updating elevation data, you check the elevation for center and all bottom points, and update the roof points. Not recommended, because it will be very slow.

Yes, it makes sense, but it's not so simple.
I foresee that when trying to generate relations (outer way + inner ways) this will have many artifacts due to triangulation.
If only generate outer way, the building will not look as marked on OSM.
It's a pretty difficult dilemma. Let me think about this a little.
In any case, thanks for the information.