Buildings plugin (Page 1 of 2)

Hello.

For some reason, OSM Overpass API sometimes does not return buildings that are marked on OSM.
Honestly, I do not know why this happens.
In Online Maps v2.6 it is planned to add generation of buildings based on Mapbox and Mapzen.

We plan to release Online Maps v2.6 in the summer.
But it is quite possible it will be Online Maps v3, because it will have a lot of changes.

OnlineMapsBuildings.OnBuildingCreated
http://infinity-code.com/doxygen/online … 72246c0d9e

This event is called for each building.

You can do it this way:
After the first call of this event, you wait for the frame when this event is not called.
This means that all buildings have already been created.

Example:

using System;
using System.Reflection;
using UnityEngine;

public class WaitingBuildingsCreation:MonoBehaviour
{
    private bool hasBuildingCreated = false;
    private bool firstBuildingCreated = false;
    private OnlineMapsBuildings buildings;

    private void Start()
    {
        buildings = OnlineMapsBuildings.instance;

        if (buildings.zoomRange.InRange(OnlineMaps.instance.zoom))
        {
            buildings.OnBuildingCreated += OnBuildingCreated;
            buildings.OnRequestSent += OnRequestSent;
        }
        else OnFinish();
    }

    private void OnRequestSent()
    {
        // Dirty hack to find out that the map does not have buildings.
        Type btype = typeof(OnlineMapsBuildings);
        FieldInfo field = btype.GetField("osmRequest", BindingFlags.Instance | BindingFlags.NonPublic);
        OnlineMapsOSMAPIQuery request = field.GetValue(buildings) as OnlineMapsOSMAPIQuery;
        request.OnComplete += OnRequestComplete;

        buildings.OnRequestSent -= OnRequestSent;
    }

    private void OnRequestComplete(string s)
    {
        if (s.Length < 300) OnFinish();
    }

    private void OnBuildingCreated(OnlineMapsBuildingBase building)
    {
        firstBuildingCreated = true;
        hasBuildingCreated = true;
    }

    private void OnFinish()
    {
        buildings.OnBuildingCreated -= OnBuildingCreated;

        Debug.Log("All buildings are created.");
        Destroy(this);
    }

    private void Update()
    {
        if (!firstBuildingCreated) return;
        if (hasBuildingCreated)
        {
            hasBuildingCreated = false;
            return;
        }

        OnFinish();
    }
}

That did the trick perfectly, thanks.

One thing I mentioned that you didn't respond to, though, is the fact that when you have both elevation and buildings turned on, the slope of the map (especially when you use an elevation multiplier to exaggerate the terrain features) causes the bottom of the building to not reach the surface of the map mesh, causing a visible gap to appear.

Not sure if that's something you'd want to tweak in your code so it doesn't happen, or if there's a way for me to vertically stretch the buildings during/after the creation process so they extend through the surface of the map. Anything the sticks out past the bottom won't be visible, and the building will reach the surface of the lowest elevations of its footprint, keeping any gaps from showing up.

Let me know if I'm not explaining myself clearly and I'll give you some coordinates and properties so you can see it for yourself.

Thanks a heap!

Thanks!

Looks like I might need to mess with it a bit, as I'm noticing that not only are there gaps at the bottom when there's a significant elevation change, but sometimes the tops of the building disappear under the terrain if it rises too high. I could just make all the buildings higher in the settings for the Buildings component in the Inspector, but I don't want it to affect buildings it doesn't need to.

What I'm trying to aim for is all buildings being the same height above the highest elevation point and reaching all the way down (or past and through) their lowest elevation point. If it's easy for you to make that adjustment in the code you provided above, that'd be great, otherwise I'll see what I can do and let you know if I need assistance.

You have several ways:
1. The easiest way is increase "Min Building Height".
2. When updating elevation data, you check the elevation for key points (for example, center + middle of bounding box edges), and update the roof points. It will be very similar to the example above (post 11), and I think you will do it without problems.
3. When updating elevation data, you check the elevation for center and all bottom points, and update the roof points. Not recommended, because it will be very slow.

Yes, it makes sense, but it's not so simple.
I foresee that when trying to generate relations (outer way + inner ways) this will have many artifacts due to triangulation.
If only generate outer way, the building will not look as marked on OSM.
It's a pretty difficult dilemma. Let me think about this a little.
In any case, thanks for the information.

After poking at it a bit more, I've decided to use the following code for the time being.

requestData = String.Format("(way[{4}]({0},{1},{2},{3});relation[{4}]({0},{1},{2},{3}););out;>;out skel qt;", bry, tlx, tly, brx, "'building'");

It doesn't cut out the holes by implementing the inner ways, but for my purposes at the moment that's acceptable. At some point later I'll want to revisit the issue if you haven't fixed it by then, but just having the exterior borders of every building defined is worth the loss of the interior spaces.

I'd rather have all the buildings be there with some of them being imperfect than the ones that would be imperfect not there at all.

Thanks again!

Wondering if you've had a chance to think on this more. As it stands, any time you update I need to keep replacing your code with the line I mentioned in post 16 so that there aren't buildings that don't show up at all.

You said, "If only generate outer way, the building will not look as marked on OSM." To me, at least, that would be preferable to the building now showing up at all. I haven't had a chance to mess with the CSG asset I mentioned yet, and hopefully I won't have to if your team can come up with a workable solution. Please let me know your thoughts on the matter.

Thanks!

That's great, thanks. I'll hold off then on implementing the code you provided above, since a better version is due later this week. I appreciate the example, though, as it shows me how to modify such calls should I need to.

I'm actually considering adapting the building code to allow me to draw lines on the map to represent ways and relations found in OSM- the border of a playground, for example, or a golf course, or some other feature that isn't a building. If you have any examples or suggestions on how to do it more easily, I'd love to see them. If not, I'll work on it myself and if I get to the point where I've got something I think the community would find useful, I'll be sure to share it here.

I have the code you provided for detecting when all the building have been rendered working, but don't get exactly how you're using it. As I'm working more in the initialization routines of my scene, I find myself wanting to be sure I understand it. Could I ask you to explain it a bit? I'm adding in some comments to explain my confusion and what I think's going on. Thanks!

Awesome, that makes sense. I appreciate the explanation.

I'll also be sure to go ahead and implement OnlineMapsBuildings.OnAllBuildingsCreated. Does this trigger if there are no buildings to create, or must the code in OnRequestSent still be run?

Also, on another note earlier in this thread, and since I missed some of the updates more recently, has there been any change in the way donut-shaped buildings are handled? Last I heard I think it was just the outer way defining the building, so at least they were showing up somewhat properly.